Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Ruby 3.4-dev #4411

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Fixes for Ruby 3.4-dev #4411

merged 2 commits into from
Mar 6, 2024

Conversation

ashie
Copy link
Member

@ashie ashie commented Feb 22, 2024

Which issue(s) this PR fixes:
N/A

What this PR does / why we need it:
CI is failed on Ruby 3.4-dev:
https://github.com/fluent/fluentd/actions/runs/7949585800

Docs Changes:
N/A

Release Note:
N/A

base64, csv and drb gems aren't part of the default gems since Ruby
3.4.0.

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie marked this pull request as ready for review March 6, 2024 03:07
@ashie ashie requested a review from kenhys March 6, 2024 03:07
Copy link
Contributor

@kenhys kenhys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kenhys kenhys merged commit c56f91e into master Mar 6, 2024
16 checks passed
@kenhys kenhys deleted the fix-ruby-3.4-dev branch March 6, 2024 03:11
@ashie ashie added this to the v1.17.0 milestone Apr 30, 2024
Watson1978 added a commit to Watson1978/fluentd that referenced this pull request Aug 15, 2024
logger gem was marked as bundled gem for Ruby 3.5.
Therefore, it will not work on Ruby 3.5 unless it is added as a dependency.
Ref. ruby/ruby@d7e558e

Similar with fluentGH-4411
Watson1978 added a commit to Watson1978/fluentd that referenced this pull request Aug 15, 2024
logger gem was marked as bundled gem for Ruby 3.5.
Therefore, it will not work on Ruby 3.5 unless it is added as a dependency.
Ref. ruby/ruby@d7e558e

Similar with fluentGH-4411
Watson1978 added a commit to Watson1978/fluentd that referenced this pull request Aug 15, 2024
logger gem was marked as bundled gem for Ruby 3.5.
Therefore, it will not work on Ruby 3.5 unless it is added as a dependency.
Ref. ruby/ruby@d7e558e

(Currently, this patch will suppress `warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.` message.)

Similar with fluentGH-4411
Watson1978 added a commit to Watson1978/fluentd that referenced this pull request Aug 15, 2024
logger gem was marked as bundled gem for Ruby 3.5.
Therefore, it will not work on Ruby 3.5 unless it is added as a dependency.
Ref. ruby/ruby@d7e558e

(Currently, this patch will suppress `warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.` message.)

Similar with fluentGH-4411

Signed-off-by: Watson <[email protected]>
daipom pushed a commit that referenced this pull request Aug 15, 2024
logger gem was marked as bundled gem for Ruby 3.5.
Therefore, it will not work on Ruby 3.5 unless it is added as a dependency.
Ref. ruby/ruby@d7e558e

(Currently, this patch will suppress `warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.` message.)

Similar with GH-4411

Signed-off-by: Watson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants